This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
DataTransferObjectError::invalidType : get actual type before mutating $value for the error message #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is an error and wasn't caught so far because no tests for the actual message did exist.
In
\Spatie\DataTransferObject\DataTransferObjectError::invalidType
this code was executed:but it was done so after
$value
was possible overwritten like this:Which basically made
gettype($value);
to yieldstring
in the majority of cases.This PR fixes this.
Please also see the 2nd commit stand-alone, showing the change form the old to the new message => 182c925